Unit test for removing callback severance on 5-to-3 adapter #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
approved these changes
Oct 25, 2023
Comment on lines
+3207
to
+3208
| // If the incomplete operation callback was not called, there would be a memory leak as the callback data was not | ||
| // released |
There was a problem hiding this comment.
Debatable: Maybe pass to Publish operation a callback which will set flag, something like is_callback_called. Then if callback is not called, we have a clear ASSERT statement indicating what the exact problem is. Currently, you have to go to this code and read this comment to figure out why memory leak appeared.
There was a problem hiding this comment.
Thinking about it, we actually could not find a good timing to validate the is_callback_called flag, because we do not know when does the callback is called during the termination process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.