feat(bedrock): New embedding model config #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-rafams
requested review from
krokoko,
MichaelWalker-git,
dineshSajwan and
alexa-perlov
krokoko
reviewed
Aug 27, 2024
krokoko
previously approved these changes
Aug 27, 2024
|
Failing build |
I see it fails because of an assert on the integ test snapshot. It did work locally. I was having similar problems and that's why I had to comment out part of the code. Will look into it. |
|
seems the assert fails due to some non-deterministic name generation and my local build succeeds due to some local caching, will continue to look into a possible solution |
aws-rafams
force-pushed
the
new-embedding-model-config
branch
from
cf8819a to
4d9f4ab
Compare
krokoko
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657
Also addressing #492
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.