feat: parse expressions in x-kubernetes-preserve-unknown fields
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
force-pushed
the
nested-schemaless-resources
branch
from
c690500 to
929a161
Compare
michaelhtm
reviewed
Dec 27, 2024
Previously, fields marked with `x-kubernetes-preserve-unknown-fields` were skipped during parsing. Now these fields are parsed to extract expressions, allowing for variable substitution in schemaless fields while still preserving unknown fields as specified by the k8s-open-api extension.
a-hilaly
force-pushed
the
nested-schemaless-resources
branch
from
929a161 to
8ff3c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
Merge after #174
Previously, fields marked with
x-kubernetes-preserve-unknown-fieldswere skippedduring parsing. Now these fields are parsed to extract expressions, allowing for
variable substitution in schemaless fields while still preserving unknown fields
as specified by the k8s-open-api extension.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.