Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made group name configurable within resourcegroup #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RinkiyaKeDad
Copy link

Issue #, if available: #164

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Arsh Sharma <[email protected]>
@RinkiyaKeDad
Copy link
Author

@a-hilaly I need some help figuring out how do I run kro locally to test my changes. I created an issue to document this process as well: #177

This is what I tried:

  • Installed kro using the helm chart in a local k3d cluster.
  • Ran make run after making my changes so that I could test them

I assumed this would have the controller running locally on my machine and the cluster would use that instead of the helm installed one but that was not the case because I kept getting this error:

❯ k apply -f resourcegroup.yaml
Error from server (BadRequest): error when creating "resourcegroup.yaml": ResourceGroup in version "v1alpha1" cannot be handled as a ResourceGroup: strict decoding error: unknown field "spec.schema.group"

Can you please help out with how do I run these changes I made to kro locally? I can then create a guide and add to the CONTRIBUTING.md as well for future contributors.

@michaelhtm
Copy link
Contributor

Hey @RinkiyaKeDad, thanks for contributing to kro
Good catch, I will take a look at the Contributing doc.

After making changes, you can run the controller locally with the following command:

go run -tags=dev cmd/controller/main.go 

Make sure to install the updated CRD when making changes to it, if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants