-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing FUSE file descriptors as mount point #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:07 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 11:39 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:31 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:31 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:31 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:32 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:32 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:32 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 13:32 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
had a problem deploying
to
PR integration tests
November 5, 2024 14:11 — with
GitHub Actions
Failure
unexge
temporarily deployed
to
PR integration tests
November 5, 2024 14:23 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
November 5, 2024 14:23 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
December 17, 2024 10:50 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
December 17, 2024 10:50 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
December 17, 2024 10:50 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
December 17, 2024 10:50 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
December 17, 2024 10:50 — with
GitHub Actions
Inactive
unexge
temporarily deployed
to
PR integration tests
December 17, 2024 10:50 — with
GitHub Actions
Inactive
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
December 17, 2024 12:01 — with
GitHub Actions
Waiting
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
force-pushed
the
fuse-fd-support
branch
from
December 17, 2024 12:04
4452882
to
17f20dc
Compare
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 17, 2024 12:04 — with
GitHub Actions
Inactive
dannycjones
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @unexge!
vladem
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fuser v0.15.0 added support for creating a
Session
from existing FUSE file descriptor (viaSession::from_fd
). This PR adds this support to Mountpoint. It allows passing FUSE file descriptor as mount point in the form of/dev/fd/{fd}
.An example usage of this feature can be seen with a helper Go script, mounthelper.go:
Relevant issues: This PR resurrects a previous PR to add this feature: #537
Does this change impact existing behavior?
Shouldn't affect any existing behavior as we had an “is directory?” check for passed mount points before, and it shouldn't have been possible to pass a file descriptor as a mount point prior to this change.
Does this change need a changelog entry in any of the crates?
Updated CHANGELOG for
mountpoint-s3
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).