Merge pull request #91 from axieinfinity/feature/runtime-config

feat(RuntimeConfig): disable artifact generation while post checking
axieinfinity · Feb 20, 2024 · 3db11cc · 3db11cc
2 parents 3aa1ca2 + 3d74017
commit 3db11cc
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 1 deletion.
diff --git a/script/ArtifactFactory.sol b/script/ArtifactFactory.sol
@@ -38,7 +38,7 @@ contract ArtifactFactory is IArtifactFactory {
       ).green(),
       string.concat("(nonce: ", nonce.toString(), ")")
     );
-    if (!CONFIG.getRuntimeConfig().log) {
+    if (!CONFIG.getRuntimeConfig().log || CONFIG.isPostChecking()) {
       console.log("Skipping artifact generation for:", vm.getLabel(contractAddr), "\n");
       return;
     }

diff --git a/script/configs/RuntimeConfig.sol b/script/configs/RuntimeConfig.sol
@@ -12,11 +12,20 @@ abstract contract RuntimeConfig is IRuntimeConfig {
   bool internal _resolved;
   Option internal _option;
   string internal _rawCommand;
+  bool internal _isPostChecking;
 
   function getCommand() public view virtual returns (string memory) {
     return _rawCommand;
   }
 
+  function isPostChecking() public view virtual returns (bool) {
+    return _isPostChecking;
+  }
+
+  function setPostCheckingStatus(bool status) public virtual {
+    _isPostChecking = status;
+  }
+
   function resolveCommand(string calldata command) external virtual {
     if (_resolved) return;
     if (bytes(command).length != 0) {

diff --git a/script/extensions/ScriptExtended.s.sol b/script/extensions/ScriptExtended.s.sol
@@ -15,6 +15,7 @@ abstract contract ScriptExtended is Script, StdAssertions, IScriptExtended {
 
   bytes public constant EMPTY_ARGS = "";
   IGeneralConfig public constant CONFIG = IGeneralConfig(LibSharedAddress.CONFIG);
+  bool internal _isPostChecking;
 
   modifier logFn(string memory fnName) {
     _logFn(fnName);
@@ -48,7 +49,10 @@ abstract contract ScriptExtended is Script, StdAssertions, IScriptExtended {
     CONFIG.resolveCommand(command);
     (bool success, bytes memory data) = address(this).delegatecall(callData);
     success.handleRevert(msg.sig, data);
+
+    CONFIG.setPostCheckingStatus({ status: true });
     _postCheck();
+    CONFIG.setPostCheckingStatus({ status: false });
   }
 
   function network() public view virtual returns (TNetwork) {

diff --git a/script/interfaces/configs/IRuntimeConfig.sol b/script/interfaces/configs/IRuntimeConfig.sol
@@ -7,6 +7,10 @@ interface IRuntimeConfig {
     bool trezor;
   }
 
+  function isPostChecking() external view returns (bool);
+
+  function setPostCheckingStatus(bool status) external;
+
   function getCommand() external view returns (string memory);
 
   function resolveCommand(string calldata command) external;