Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for creating nice DMG installation image #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Script for creating nice DMG installation image #26

wants to merge 3 commits into from

Conversation

jirutka
Copy link

@jirutka jirutka commented Mar 11, 2012

Hi,

I wrote configuration for yoursway-create-dmg that creates DMG disk image for distributing MacVim in proper Mac way. Also created background image for it. However, I don't know how to properly integrate it to the build process of MacVim, but script itself is working well, as you can see – http://jirutka.cz/MacVim_7.3b64.dmg.

MacVim developers, please integrate it to the build process. I don't know how to do that properly.
@jirutka
Copy link
Author

jirutka commented Mar 11, 2012

MacVim logo that I used is from http://dribbble.com/shots/121306-MacVim-Replacement-Icon.

@necolas
Copy link

necolas commented Mar 12, 2012

This is the latest version of that logo http://dribbble.com/shots/337065-MacVim-Icon-Updated

IMO, this logo is much nicer than the standard Vim logo. I hope there can be some way for you to include it in future versions of MacVim.

@jirutka
Copy link
Author

jirutka commented Mar 12, 2012

@necolas I found this updated version just after I’ve send commit with the old one and didn’t want to modify it again. However today I had some time on little boring lecture so there’s update. And also commit with replaced application icon with this new one.

You can see how it looks – http://jirutka.cz/MacVim_7.3b64_new_icon.dmg (legacy version for Snow Leopard) – or modify any other version yourself.

@b4winckler
Copy link
Owner

Thanks for the patch.

Having a dmg instead of an archive is nice and something I just never got around to investigating, so this might come in handy. Changing the icon is not an option however -- I have discussed why at length on the vim_mac mailing list, so please look at my reasoning there.

@jirutka
Copy link
Author

jirutka commented Mar 13, 2012

@b4winckler It’s pity, this new logo is really much nicer. Could it be at least on the background picture for DMG, or should I replace it with the original (ugly) one? In the first two patches is still original icon and new one is only in the background image, so if it would be okay, you can use it. Otherwise I will send new patch.

@djcas9
Copy link

djcas9 commented Mar 25, 2012

@necolas @jirutka it's a nice logo (besides the python code in the background) but I agree with @b4winckler it should not deviate from the vim logo.

@teoljungberg
Copy link

If you want the new logo, create a shell-script that fetches the logo and installes in on top off the older one

@eirnym
Copy link

eirnym commented Jul 14, 2015

@jirutka Can you apply same pull request for https://github.com/macvim-dev/macvim ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants