This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Extremely dirty workaround for not responsive nav buttons #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filthy 😂
Richard
…On 9 Feb 2019, 13:15 -0500, Michał Osadnik ***@***.***>, wrote:
You can view, comment on, or merge this pull request online at:
#425
Commit Summary
• Extremely dirty workaround for not responsive nav buttons
File Changes
• M src/App.js (2)
• M src/components/header/CameraHeaderButton.js (5)
• M src/components/header/ProfileHeaderButton.js (7)
• M src/screens/ProfileScreenWithData.js (5)
• M src/screens/QRScannerScreenWithData.js (6)
• M src/screens/WalletScreen.js (6)
Patch Links:
• https://github.com/balance-io/balance-wallet/pull/425.patch
• https://github.com/balance-io/balance-wallet/pull/425.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed some race condition on jumping between tabs using two methods (with swipe and navbuttons) and noticed that sometimes index of tab is incorrect. Probably it's an internal bug since it's not related to any app logic.
Of course, it's not recommendable to write it manually, but 🤷♀️