Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add fan profile and power mode info to docs #3548

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Nov 4, 2024

This commit adds detailed information for the
new power and cooling configuration options
available for Jetson Orin devices.

Change-type: patch

Connects-to: balena-io/docs#3099


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@acostach acostach requested a review from cywang117 November 4, 2024 14:00
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com November 4, 2024 14:00 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 13, 2024 16:36 — with GitHub Actions Inactive
@acostach acostach requested a review from cywang117 December 13, 2024 16:43
@acostach acostach marked this pull request as ready for review December 13, 2024 16:43
@acostach acostach requested a review from a team December 13, 2024 16:43
@acostach acostach enabled auto-merge December 13, 2024 16:54
@acostach acostach temporarily deployed to balena-staging.com December 14, 2024 12:35 — with GitHub Actions Inactive
@acostach acostach temporarily deployed to balena-staging.com December 14, 2024 12:35 — with GitHub Actions Inactive
@acostach acostach merged commit ffa4d79 into master Dec 14, 2024
163 of 165 checks passed
@acostach acostach deleted the add_fan_power_mode_docs branch December 14, 2024 13:35
@@ -315,6 +315,41 @@ The following example contains two custom udev rules that will create `/etc/udev
}
```

#### fan

An object that defines thermal related configuration. Available for Jetson Orin devices running Jetpack 6 or newer, balenaOS v6.1.24 or newer and Supervisor v16.10.0 or newer.
Copy link
Contributor

@alexgg alexgg Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize I am late for this - it really bothers me seeing that we are breaking the separation between meta-balena and device repositories. imo, the feature should have been designed generic even if only the Jetson Orin device is actually using it, and this mention to Jetson Orin should be removed. It sets a bad precedent and will make it more confusing to maintain the OS in future.

Also, balenaOS and supervision version are implied - the field is supported from the version where the README is updated. I really think adding these details is a bad practise.

@klutchell @acostach

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there is a way we can avoid creating a "special butterfly" situation out of this which is what orin will become.


#### power

An object that defines power consumption related configuration. Available for Jetson Orin devices running Jetpack 6 or newer, balenaOS v6.1.24 or newer and Supervisor v16.10.0 or newer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants