-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Add fan profile and power mode info to docs #3548
Conversation
@@ -315,6 +315,41 @@ The following example contains two custom udev rules that will create `/etc/udev | |||
} | |||
``` | |||
|
|||
#### fan | |||
|
|||
An object that defines thermal related configuration. Available for Jetson Orin devices running Jetpack 6 or newer, balenaOS v6.1.24 or newer and Supervisor v16.10.0 or newer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize I am late for this - it really bothers me seeing that we are breaking the separation between meta-balena and device repositories. imo, the feature should have been designed generic even if only the Jetson Orin device is actually using it, and this mention to Jetson Orin should be removed. It sets a bad precedent and will make it more confusing to maintain the OS in future.
Also, balenaOS and supervision version are implied - the field is supported from the version where the README is updated. I really think adding these details is a bad practise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there is a way we can avoid creating a "special butterfly" situation out of this which is what orin will become.
|
||
#### power | ||
|
||
An object that defines power consumption related configuration. Available for Jetson Orin devices running Jetpack 6 or newer, balenaOS v6.1.24 or newer and Supervisor v16.10.0 or newer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem
This commit adds detailed information for the
new power and cooling configuration options
available for Jetson Orin devices.
Change-type: patch
Connects-to: balena-io/docs#3099
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines