eks: make aws-auth ConfigMap future compatible #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonifaido
force-pushed
the
eks-mapRoles-future-proof
branch
from
3afb67f to
7186520
Compare
Signed-off-by: Nandor Kracser <[email protected]>
bonifaido
force-pushed
the
eks-mapRoles-future-proof
branch
from
7186520 to
41852d8
Compare
stoader
approved these changes
Feb 7, 2020
pepov
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nandor Kracser [email protected]
What's in this PR?
Why?
The aws-iam-authenticator doesn't handle path currently in role mappings: kubernetes-sigs/aws-iam-authenticator#268
Once this bug gets fixed our code won't work, so we are making it future compatible by adding the role id with and without a path to the mapping. Since IAM role IDs are unique within an account this is not a security concern.
Additional context
Checklist