This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Explain the project purpose #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a bug in build script when not running on docker, so I'm delaying this change until that's fixed. |
|
#68 fixes the missing carton command bug. This PR can be merged after that. |
|
I would not have documented how the build works* but I'm ok with the README if you guys like it.
|
Maybe it'd be better to have the build instructions on their own I'm OK with removing the build steps and move them somewhere else. |
They don't fit in the main README, so it'd be better to move them elsewhere (e.g. on source directory or as comments in build script).
alexm
changed the title
|
Build instructions removed, so #68 is no longer blocking this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a brief history of the event and some build instructions.