Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on HTTP 404 #172

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Retry on HTTP 404 #172

merged 1 commit into from
Oct 16, 2024

Conversation

ouillie
Copy link
Contributor

@ouillie ouillie commented Oct 16, 2024

Follow-up to #170. I suppose this is what we get for unit-testing but not e2e-testing. On the other hand, I don't have the means to e2e-test this myself, so this is the best I can do right now.

@ouillie ouillie mentioned this pull request Oct 16, 2024
Closed
kormide
kormide approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@kormide kormide left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the e2e tests just require you to have gcloud credentials on your local machine. It doesn't actually use them, but the creation of the client requires that some files exist IIRC. I ran the tests locally and they pass.

@kormide kormide merged commit 1b005c2 into bazel-contrib:main Oct 16, 2024
2 checks passed
@kormide
Copy link
Collaborator

kormide commented Oct 16, 2024

I deployed this to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouillie @kormide