Allow library tool resource handling to be disabled #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/allow-not-wrapping-resources-in-filegroup
branch
2 times, most recently
from
bfb48cf to
7ddd02c
Compare
luispadron
force-pushed
the
luis/allow-not-wrapping-resources-in-filegroup
branch
from
7ddd02c to
cc69e9b
Compare
jszumski
approved these changes
Nov 19, 2024
congt
reviewed
Nov 19, 2024
luispadron
force-pushed
the
luis/allow-not-wrapping-resources-in-filegroup
branch
from
cc69e9b to
f5a18b3
Compare
congt
approved these changes
Nov 19, 2024
luispadron
deleted the
luis/allow-not-wrapping-resources-in-filegroup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the wrap resource in filegroups and resource bundle generators to be disabled completely. It allows users to just pass in
dataand have the rule just forward that to the underlying libraries.This cleans up the code a bit too since we use
datadirectly instead ofmodule_datawhich had to be converted into a list in a few places.I added a test showcasing where this ability would be required. It fails without this change and passes when disabling the library tools