-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to objc_provider and remove force_load_direct_deps to support rules_apple > 3.15.0 #934
base: master
Are you sure you want to change the base?
Conversation
@luispadron If I can get your review that'd be fantastic 🙏 |
@@ -29,7 +29,7 @@ jobs: | |||
XCODE_VERSION: ${{ matrix.xcode_version }} | |||
USE_BAZEL_VERSION: ${{ matrix.bazel_version }} | |||
LATEST_RULES_SWIFT_VERSION: 2.1.1 | |||
LATEST_RULES_APPLE_VERSION: 3.8.0 | |||
LATEST_RULES_APPLE_VERSION: 3.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this line because CI was complaining about this (do let me know if this isnt right)
Thanks for getting the work started here! I think theres some left-over usage:
Do we need to upgrade rules_apple in |
@luispadron I think when I didnt change rules_apple to 3.15.0, I got build errors that rules_apple was expecting the objc_provider parameter. I would vote to drop Bazel 6 support mainly because
What do you think? If you’d think its fine to drop support for Bazel 6, I’m happy to start that PR before we let this in. |
Yeah I think it makes sense! @thiagohmcruz @gyfelton FYI in case we have some reason for keeping Bazel 6 |
Okay perfect. I can start that PR and will tag you along. I’ll likely complete it after New Years when I am back from vacation. |
With rules_apple removing legacy objc_providers, rules_apple > 3.15.0 is no longer compatible with rules_ios due to Remove legacy Objc provider linking support bazelbuild/rules_apple#2611
Removing force load direct deps as its no longer needed in Bazel 7 Consider removing
force_load_direct_deps_rule
in Bazel 7+ #862This PR is attempt to make rules_ios compatible with rules_apple + remove the legacy code to force load direct deps as with Bazel 7,
--incompatible_objc_alwayslink_by_default
does the same thing.