-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update base bifold packages #2334
Conversation
4904e79
to
64e21e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add enableHiddenDevModeTrigger: true,
to container-imp.ts
around line 220? Just to the config. This will allow us to get to developer mode from the enter PIN screen
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
64e21e6
to
e55cfb7
Compare
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Quality Gate passedIssues Measures |
Several changes in this PR, all knock on fixes from the original Boost issue.
1. Update base Bifold packages
Update base Bifold packages.
2. Update React Native
JFrog shutdown their mirror hosting the boost package used by React Native 0.72.5. This is causing the builds to fail because CICD does not cache this package. Probably working for developers because we have it cached. To fix this I updated to the latest hot-fix version of react native 0.72. I also removed
@types/react-native
because when that is a stub package - react native comes with its own types.to
3. Update minimum SDK to fix Android compilation error
The Android build step was failing failing with a compilation issue.
Fixes #2329
Fixes #2335