Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update base bifold packages #2334

Merged
merged 6 commits into from
Jan 8, 2025
Merged

feat: update base bifold packages #2334

merged 6 commits into from
Jan 8, 2025

Conversation

jleach
Copy link
Member

@jleach jleach commented Jan 7, 2025

Several changes in this PR, all knock on fixes from the original Boost issue.

1. Update base Bifold packages

Update base Bifold packages.

2. Update React Native

JFrog shutdown their mirror hosting the boost package used by React Native 0.72.5. This is causing the builds to fail because CICD does not cache this package. Probably working for developers because we have it cached. To fix this I updated to the latest hot-fix version of react native 0.72. I also removed @types/react-native because when that is a stub package - react native comes with its own types.

ios git:(feat/update-base-pkg) ✗ cat ../node_modules/react-native/third-party-podspecs/boost.podspec|grep "spec.source"
spec.source = { :http => 'https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2',

to

ios git:(feat/update-base-pkg) ✗ cat ../node_modules/react-native/third-party-podspecs/boost.podspec|grep "spec.source"
spec.source = { :http => 'https://archives.boost.io/release/1.76.0/source/boost_1_76_0.tar.bz2',
1b44865bc76f4

3. Update minimum SDK to fix Android compilation error

The Android build step was failing failing with a compilation issue.

Fixes #2329
Fixes #2335

@jleach jleach requested a review from bryce-mcmath January 7, 2025 18:51
@jleach jleach self-assigned this Jan 7, 2025
@jleach jleach requested a review from al-rosenthal January 7, 2025 18:51
@jleach jleach force-pushed the feat/update-base-pkg branch from 4904e79 to 64e21e6 Compare January 7, 2025 18:54
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add enableHiddenDevModeTrigger: true, to container-imp.ts around line 220? Just to the config. This will allow us to get to developer mode from the enter PIN screen

jleach added 3 commits January 7, 2025 10:58
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach requested a review from bryce-mcmath January 7, 2025 18:59
@jleach jleach enabled auto-merge (squash) January 7, 2025 18:59
@jleach jleach force-pushed the feat/update-base-pkg branch from 64e21e6 to e55cfb7 Compare January 7, 2025 19:00
al-rosenthal
al-rosenthal previously approved these changes Jan 7, 2025
bryce-mcmath
bryce-mcmath previously approved these changes Jan 7, 2025
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach dismissed stale reviews from bryce-mcmath and al-rosenthal via 9b7ecd5 January 7, 2025 20:30
@jleach jleach disabled auto-merge January 7, 2025 20:30
@bryce-mcmath bryce-mcmath self-requested a review January 7, 2025 20:35
bryce-mcmath
bryce-mcmath previously approved these changes Jan 7, 2025
al-rosenthal
al-rosenthal previously approved these changes Jan 7, 2025
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach dismissed stale reviews from al-rosenthal and bryce-mcmath via 3dd4384 January 7, 2025 22:24
Signed-off-by: Jason C. Leach <[email protected]>
Copy link

sonarqubecloud bot commented Jan 8, 2025

@bryce-mcmath bryce-mcmath merged commit cfac125 into main Jan 8, 2025
16 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/update-base-pkg branch January 8, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing to install package Bifold package publishing error
3 participants