Added supprot for network rx/tx #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just created the PR #212 and decided to check other PRs and was extremely confused that you already added the column in your PR :) Could you please check which solution is better? |
stokito
approved these changes
Oct 26, 2020
stokito
suggested changes
Oct 29, 2020
|
@stokito Your solution is good, but we have different branches, my solution for k8s integration. But I did the solution 2 years ago for 1.15.5 (if I remember right) version k8s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcicen I did created two structs for work with values from k8s #59 API response, because I didn't found struct in API packages :-(