#191 Docker Compose support #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokito
force-pushed
the
docker_compose
branch
from
5c180e9 to
145ed61
Compare
During debug it may happen that c.stream is already closed but we are trying to send a metric to the closed channel
Instead of setting all fields to -1 we can set them to zero. Since zero is a default fields value then we can omit manual initialization. This means that we don't need the whole New() method
Each container have a Project which may represent a Docker Compose project. The name of project is simply the name of folder from which `docker-compose up` executed. If container was started not from Compose then it anyway will be assigned to the noneProject with empty name. Each project will be rendered as a separate CompactRow widget. Currently to determine that this line is a project instead of status will be shown a down arrow ▼. TBD: use ident instead. All containers will be sorted by the project first and only then by name. On rendering in grid.go we know that containers from the same project are always together. Rendered result looks like: ▼ ◉ container1 ◉ container2 ▼ proj1 ◉ proj1_db ◉ proj1_serv ▼ proj2 ◉ proj2_db ◉ proj2_serv
We can't sort by id ot status as we did it for project's metrics. But at least inside of a project we can sort. I.e. we anyway sort by project name and only then by status or id
stokito
force-pushed
the
docker_compose
branch
from
145ed61 to
bd494d0
Compare
# Conflicts: # connector/docker.go
Portainer uses term Stack for Docker Compose projects so to make terminology familiar let's rename in ctop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First few commits are kind of refactoring and preparation for the next commits with feature.
Please read comments with description.
To be done: