Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize beets.test packaging #5084

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

sumpfralle
Copy link
Contributor

Description

Include beets.test in the release build

For now (see 508d28f) just the python code was added.
But the new package was not mentioned, yet.

The other commit in this pull request applies alphabetical ordering to all items mentioned in setup.py.

@sumpfralle
Copy link
Contributor Author

sumpfralle commented Jan 17, 2024

The "missing changelog entry" CI test failed.
I think, this change does not deserve a changelog entry, since it is strictly a change of the build recipe (which is already covered in the previous changelog entry regarding beets.test).

Update: somehow the changelog test seemed to have failed before. Now it is gone. Thus, ignore my comment.

In commit 508d28f the package `beets.test` was introduced.
But it was not added to the list of packages in `setup.py`.
Thus, it was not part of a beets installation for now.
@sumpfralle sumpfralle force-pushed the finalize-beets-test-exposure branch from 21611e8 to 3c2a66e Compare January 17, 2024 23:14
@Serene-Arc Serene-Arc self-assigned this Jan 18, 2024
@Serene-Arc
Copy link
Contributor

Seems fine to me!

@Serene-Arc Serene-Arc merged commit 7f1250d into beetbox:master Jan 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants