Resolve some 'mypy' errors #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to account for merge conflicts. |
|
Many remaining mypy errors are from |
snejus
reviewed
Jun 10, 2024
added 5 commits
June 12, 2024 15:58
'typing.Never' was introduced later, and 'typing.Type' was used instead of just 'type' until 3.9. This commit will likely be reverted over time as these 3.8 etc. get dropped.
In changing the implementation of the 'AttrDict' class to eliminate 'mypy' errors, I had accidentally removed support for storing 'None' values in the dict. This commit restores support for them.
Apparently Python 3.8 does not support generic type parameters on the built-in 'queue.Queue' type?
I had misinterpreted the pattern type for this query to be 'NoReturn', thinking that it accepted no pattern at all (even so, I should have typed it as 'None'). However, it does accept a pattern, and uses it to decide whether to select only singletons or none at all. See <beetbox#5282 (comment)>.
|
I don't think this PR needs a changelog entry, but please confirm if so. |
|
Nah I don't think the changelog entry is needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that some development work was waiting on cleaner
mypyruns, so I thought I would help out a bit. This PR just contains a number of miscellaneous fixes across the codebase that I hit. I'm happy to add more, or remove any problematic changes (though I don't think I've broken anything, only type annotations have changed).To Do
DocumentationTests