Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.8 / drop Python 3.7 #5283

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Upgrade to Python 3.8 / drop Python 3.7 #5283

merged 4 commits into from
Jun 5, 2024

Conversation

snejus
Copy link
Member

@snejus snejus commented Jun 5, 2024

Description

Fixes #5222.

Drop Python 3.7. pyupgrade is responsible for most of the changes in the code. I undid some of the bits it attempted to update that aren't strictly necessary:

  1. Converting List/Dict/Tuple -> list/dict/tuple in modules that have from __future__ import annotations import. This should be done in a separate PR, and for all modules
  2. Converting some .format( calls to f-strings. It didn't do it consistently, and it should also be done in a separate PR, I believe.

Python upgrade unblocks several other PRs, for example #5266 and #5248.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@snejus snejus self-assigned this Jun 5, 2024
@snejus snejus requested review from wisp3rwind and Serene-Arc June 5, 2024 03:35
@snejus snejus force-pushed the upgrade-to-python38 branch from e0c25f7 to 65bfbda Compare June 5, 2024 03:41
Copy link
Contributor

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good to me. Nice that 3.8 has its own lazy property functionality in functools.

@snejus snejus merged commit 1b59479 into master Jun 5, 2024
10 checks passed
@snejus snejus deleted the upgrade-to-python38 branch June 5, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should drop Python 3.7
2 participants