Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FFmpeg requirement info and links to installation guides #5533

Closed
wants to merge 1 commit into from

Conversation

hardyoyo
Copy link

@hardyoyo hardyoyo commented Dec 2, 2024

Description

@snejus
Copy link
Member

snejus commented Dec 4, 2024

By default beets does not depend on ffmpeg. Plugins like replaygain and convert do, so maybe docs of these plugins would be more relevant for these installation instructions?

@hardyoyo
Copy link
Author

hardyoyo commented Dec 5, 2024

You're right, and the Chroma plugin does mention needing FFmpeg (among other things). I believe this PR would be better if it instead directed users to investigate the dependencies of any plugins they wish to use, instead of blindly instructing folks to install FFmpeg. I'll revise it.

@hardyoyo
Copy link
Author

hardyoyo commented Dec 5, 2024

actually, this seems like an unnecessary hint... I'm just going to close this PR

@hardyoyo hardyoyo closed this Dec 5, 2024
@snejus
Copy link
Member

snejus commented Dec 5, 2024

instead directed users to investigate the dependencies of any plugins they wish to use,

Some more clarity in our docs sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants