Replace munkres with lapjv for track assignment #5564
Merged
+100
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5207.
This PR replaces the
munkres
library withlap
(Linear Assignment Problem solver) for computing optimal track assignments during the auto-tagging process. The main changes are:munkres
dependency and addlap
andnumpy
dependencieslap.lapjv()
instead ofMunkres().compute()
track_distance
function to improve performanceThe motivation for this change comes from benchmark comparisons showing that LAPJV (implemented in the
lap
library) significantly outperforms the Munkres/Hungarian algorithm for the linear assignment problem. See detailed benchmarks at: https://github.com/berhane/LAP-solversThe change should provide better performance for track matching, especially with larger albums, while maintaining the same assignment results.
Testing Notes