Allow rendering previews for larger image-files (up to 20MB) by default #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file-size of images with a resolution of 3840x2160 (or higher) can be considerably larger than the current size-limit of 10MB, if they are in lossless formats, such as PNG. Videogame-screenshots made on a 4K-display would be an example of a common source for such images.
|
Thanks for the PR. Yeah, considering that might be a popular use case, our defaults should allow that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file-size of images with a resolution of 3840x2160 (or higher) can be considerably larger than the current size-limit of 10MB, if they are in lossless formats, such as PNG.
Videogame-screenshots made on a 4K-display would be an example of a common source for such images.
Many of the videogame-screenshots which i usually have are around 11-12 MB as a PNG.
I generated a few noise-images (with an alpha-channel) for finding a good upper limit:
Those were about 17,8 MB to 19,7 MB in size, both as PNG and losslessly compressed WebP.
So, i assume that 20 MB will probably not be reached in practice, except with 8K-images, which are probably still rare.