This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Language selection is no longer available #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betapictoris
added
bug
|
Hey @Ruzie! Thanks for opening the pull request, I wasn't aware that Free Dictionary API was doing this. That being said, they said that they would keep the structure the same and that the lack of multilingual support is temporary. In the mean time the feature will, of course, not work on Dictionary CLI, I am guessing this is the reason why you closed the request. |
|
Yup! By the way, thanks for checking the PR, before I wasn't sure should I create PR or not but meanwhile I closed it. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this meetDeveloper/freeDictionaryAPI#102 English is the only language that is now supported. Dict have an optional parameter to select language, since free dictionary API have already removed this feature, passing language code will return "No definitions found error"