-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running IRIDA #589
base: master
Are you sure you want to change the base?
Conversation
@@ -130,6 +130,10 @@ COPY --chown=$GALAXY_USER:$GALAXY_USER --from=build_miniconda /etc/profile.d/con | |||
|
|||
COPY ./files/start.sh /usr/bin/start.sh | |||
|
|||
RUN usermod -aG root $GALAXY_USER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvanheus can we remove all those changes in this file? I think the Galaxy upgrade should happen in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. Also there's stuff in there that needs to be made conditional - i.e. the ability of the Galaxy and IRIDA containers to talk to each other (share users).
@pvanheus please let me know if you think this is ready. I do not expect that you fix the failing test - that are largely other problems. Of course, I appreciate any help, but just to let you know that it's not required. |
Note to self:
I guess we need to update to the latest bioblend and check what is wrong in Galaxy or bioblend.
Seems that Galaxy is building pysam for some containers under python 3.8. Not sure why, should not happen, we should use a wheel. |
Thanks to @jyotipm29 we are back on track 😄 Please give it a try:
... or any other combination. The readme has been updated. Please add any useful tip to it. For a list of changes, see the Changelog. |
This adds the ability to run IRIDA and Galaxy simultaneously. IRIDA is available on port 80 with Galaxy on port 90. Current status is that this works, but it needs cleaning up.
TODO