-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few changes #24
base: master
Are you sure you want to change the base?
A few changes #24
Conversation
… cause issues with PyPi
…ded new AllPosts and ThreadUrl attributes
…amelCase, from Anorov's fork
…es/thumb name generator
It's like `bumplimit` but for images
Add imagelimit
spoiler and custom_spoiler
…or with default values
…and functions, which is passed down to all requests. The board API had to be changed a bit: the Board class is now private (_Board), users should use any of the get_board, get_boards or get_all_boards functions to get access to a Board instance. This is to ensure that a timeout for the initial metadata request can be used
…d change their state accordingly. Post now has a new attribute: deleted.
This looks great from my preliminary analysis, I just need dan_'s assistance to test it out, and we'll merge it in and package. Thanks for the contribution. |
One should also consider if the imports in the |
I would have to figure out a way to make Board an alias to get_board for compatibility, as a lot of other scripts depend on this library. As for Url, that class does have uses for manual instantiation, though admittedly Post and Thread don't: but there could be situations where it could help. I've been moving recently, so I will have to look further into this later this week, sorry about that. |
…ntation for new attributes
…xisting docstrings for the timeout argument
I added a way to keep track of the page the thread was last seen on as best as possible and introduced a few new attributes: Additionally I added some documentation and expanded existing docstrings with information about the new arguments and/or properties introduced in this and earlier commits. The |
…en using a PriorityQueue.
…ge of a timeout parameter
Awesome. Yes, that does help us make it possible to merge, though we will still need to test it out when we have time. |
Check the commit messages for more detailed information please. There's a single API-breaking change in the board module: users are now forced to use any of the
get_board...
functions to instantiate a Board class.