Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratna: annotation results from first half of zhihan data #37

Merged
merged 12 commits into from
May 8, 2024

Conversation

ratnadiraw
Copy link
Contributor

I moved the 18 remaining codes that I didn't work on to the data/removed directory. Thank you.

@terryyz
Copy link
Collaborator

terryyz commented May 7, 2024

It seems that your script/run.sh isn't correctly set up, and therefore, no test has been run. You need to initialize NAMES to properly run over the corresponding split.

@ratnadiraw
Copy link
Contributor Author

ratnadiraw commented May 8, 2024

Hi @terryyz, if I put NAMES, then the other "zhihan" would also be run which can fail the tests. I have mentioned in the chat that I can run the test correctly in my repo:
image

The change on the run.sh also only to make sure that it ran the code that I have modified.
image

@imamnurby
Copy link
Contributor

Hi @ratnadiraw , may I know at which step this is failing? Is it when executing parse.py?
Previously I tried to change this line https://github.com/bigcode-project/open-eval/blob/c3b0fc9fe8e46a8d8cef78c26f92b121b778cb22/script/parse.py#L470 to only include zhihan data.

Here is my fork https://github.com/imamnurby/open-eval/blob/cb94d6b39b45ba81d3d47ca8fe771f192a015ad2/script/parse.py#L470.

It will only parse my split, ignoring the others.

@ratnadiraw
Copy link
Contributor Author

There is no step that fails, it just does not run here.
image

It can run just fine on my repo:
image

@ratnadiraw
Copy link
Contributor Author

ratnadiraw commented May 8, 2024

I have updated the parse.py and run.sh (+f_935, f951, 961) so it can pass the test in the workflow. Thank you!

@terryyz terryyz merged commit 4f3652c into bigcode-project:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants