Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two useful fixed for the JCP editor #60

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Two useful fixed for the JCP editor #60

wants to merge 2 commits into from

Conversation

egonw
Copy link
Member

@egonw egonw commented Mar 23, 2018

  1. one of the recent updates (to recent CDK, possible), caused that adding new atoms, implicit hydrogen counts were not updated... bit of a weird one, as there is code that is supposed to do it, but now added a line to doing it in a separate step (patch 1)
  2. this is definitely a CDK 1.5/2.0 update: wedge bonds are not directly used for SMILES stereo detection and needs to be perceived in a separate step, which it now does (I think this will have to happen in more places; patch 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@egonw