-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new tool: orthodb #51959
new tool: orthodb #51959
Changes from 83 commits
373260a
7dc3f11
dee90d3
6059f6d
dfab9f5
f606411
b5ca662
fd196b3
b3575ca
e086ff7
3e724d5
5530755
04ec3a1
601defe
97a8fac
63dc880
dd8ffc2
bddfa19
87dc0bd
e4409fe
ddd724b
f8989fa
d24a2d9
643890e
55d5d35
9c1a95f
53ecba7
80a853e
7421de7
9f7b6bd
514d7f7
487ac9b
4f8a9de
7e873c4
47ed311
93d460a
08d9f42
87fff4e
dddffad
4a57ac1
abcce90
808c3db
e80419c
82ffa61
59be8ff
0c40c01
573d5c4
735906b
80eb339
86551c8
75dcae5
8261edd
e45e7c0
51a9aa4
5318135
e3c70f5
0d6400b
fd5c5cc
8d71f36
3d57bc6
7a97f24
95baab1
15bd48c
b61eb54
274bdbc
d1a6d16
1bb2411
23eca95
15d41ec
e233d9e
c34ceb6
05b40e3
a769112
0d96419
b0ed1cf
7440f5f
73263b8
2f04e3a
9ae11da
6c29000
7b07203
cb5196c
6e64a6f
4d41d22
862004f
ec7e152
8c9e428
2364fd9
2e54c99
231052a
12c268c
75525a5
c359434
1989848
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#!/bin/bash | ||
$PYTHON -m pip install . --no-deps --ignore-installed -vv |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
{% set name = "orthodb" %} | ||
{% set version = "0.9.0" %} | ||
{% set sha256 = "b1c776e5521c809245696c0c6388f3301d10966707774fc7fecaa4cd40481bd3" %} | ||
|
||
package: | ||
name: {{ name }} | ||
version: {{ version }} | ||
|
||
build: | ||
number: 0 | ||
noarch: python | ||
run_exports: | ||
- {{ pin_subpackage('orthodb', max_pin="x") }} | ||
|
||
source: | ||
url: https://gitlab.com/ezlab/orthodb_py/-/archive/{{ version }}/orthodb_py-{{ version }}.tar.gz | ||
sha256: {{ sha256 }} | ||
|
||
requirements: | ||
build: | ||
- python >=3.9 | ||
- bash >=4.1 | ||
host: | ||
- python >=3.9 | ||
- pip | ||
- bash >=4.1 | ||
run: | ||
- python >=3.9 | ||
- bash >=4.1 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Remove unnecessary Bash dependency requirements The package only uses Bash in the build script with a simple pip install command that doesn't require any Bash-specific features. The
Please remove the Bash requirements from all sections and fix the trailing whitespace on line 30. 🔗 Analysis chainVerify Bash dependency requirement. The inclusion of Bash >=4.1 as a requirement in all sections (build, host, run) is unusual for a Python package. Please verify if this is actually needed for the package functionality. Also, there's a trailing whitespace on line 30 that should be removed. Let me generate additional scripts to check for bash script usage specifically in the orthodb package. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if the package actually uses bash in its code
rg -l 'subprocess.*bash|os.system.*bash' || echo "No direct bash usage found"
# Check if there are any shell scripts in the package
ast-grep --pattern 'from subprocess import|import subprocess'
Length of output: 11022 Script: #!/bin/bash
# Check for shell scripts in the orthodb package directory
fd -e sh . recipes/orthodb/
# Check for bash shebang in any files
rg '^#!.*bash' recipes/orthodb/
# Check build.sh and any other scripts for bash-specific features
cat recipes/orthodb/build.sh || echo "No build.sh found"
Length of output: 226 🧰 Tools🪛 yamllint[error] 30-30: trailing spaces (trailing-spaces) |
||
test: | ||
commands: | ||
- python -c 'import orthodb; api=orthodb.OdbAPI();' | ||
|
||
about: | ||
home: https://www.ezlab.org/orthodb_v12_userguide.html | ||
license: GPL3 | ||
license_family: GPL3 | ||
license_file: LICENSE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add license file to the files section The Add this section after the source section: files:
- LICENSE |
||
summary: Interface to OrthoDB REST API. | ||
description: Python interface to OrthoDB REST API with some additional functionality. | ||
dev_url: https://gitlab.com/ezlab/orthodb_py | ||
doc_url: https://www.ezlab.org/orthodb_v12_userguide.html#api | ||
|
||
extra: | ||
identifiers: | ||
- biotools:orthodb | ||
- doi:10.1093/nar/gkac996 | ||
- PMID:36350662 | ||
recipe-maintainers: | ||
- ftegenfe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove unnecessary run_exports configuration
The
run_exports
section is typically used for compiled libraries where ABI compatibility matters. For a pure Python package, this configuration is unnecessary and could potentially constrain downstream packages unnecessarily.📝 Committable suggestion