Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tool: orthodb #51959

Merged
merged 94 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from 83 commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
373260a
added orthologer
ftegenfe Nov 20, 2023
7dc3f11
WIP:orthologer
ftegenfe Nov 22, 2023
dee90d3
orthologer
ftegenfe Nov 22, 2023
6059f6d
version
ftegenfe Jan 12, 2024
dfab9f5
minor
ftegenfe Jan 12, 2024
f606411
orthologer version
ftegenfe Jul 2, 2024
b5ca662
Merge branch 'master' of github.com:bioconda/bioconda-recipes
ftegenfe Jul 2, 2024
fd196b3
updated meta
ftegenfe Jul 2, 2024
b3575ca
Merge branch 'bioconda:master' into master
ftegenfe Jul 3, 2024
e086ff7
orthologer 3.2.3
ftegenfe Jul 4, 2024
3e724d5
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Jul 4, 2024
5530755
Merge branch 'master' into master
ftegenfe Jul 4, 2024
04ec3a1
updated sha256
ftegenfe Jul 4, 2024
601defe
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Jul 4, 2024
97a8fac
Fix SHA256
martin-g Jul 4, 2024
63dc880
minor
ftegenfe Aug 21, 2024
dd8ffc2
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Aug 21, 2024
bddfa19
Merge branch 'bioconda:master' into master
ftegenfe Aug 22, 2024
87dc0bd
spdlog in meta
ftegenfe Aug 27, 2024
e4409fe
orthologer: updated cmake OpenMP detection
ftegenfe Aug 27, 2024
ddd724b
Merge branch 'bioconda:master' into master
ftegenfe Aug 27, 2024
f8989fa
last macos fixes are now actually there
ftegenfe Aug 27, 2024
d24a2d9
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Aug 27, 2024
643890e
Merge branch 'master' into master
ftegenfe Aug 27, 2024
55d5d35
meta
ftegenfe Aug 28, 2024
9c1a95f
updated brhclus - now compiles with clang
ftegenfe Aug 28, 2024
53ecba7
fix macos
ftegenfe Aug 28, 2024
80a853e
meta/bash macos
ftegenfe Aug 29, 2024
7421de7
build bash version 4
ftegenfe Aug 29, 2024
9f7b6bd
even more clang
ftegenfe Aug 29, 2024
514d7f7
more cmake and macos issues
ftegenfe Aug 29, 2024
487ac9b
updated installer
ftegenfe Aug 29, 2024
4f8a9de
Merge branch 'master' into master
ftegenfe Aug 30, 2024
7e873c4
update build and host section
ftegenfe Aug 30, 2024
47ed311
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Aug 30, 2024
93d460a
clean up recipe
mencian Sep 4, 2024
08d9f42
updated to new version
ftegenfe Sep 4, 2024
87fff4e
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Sep 4, 2024
dddffad
path not needed with new version
ftegenfe Sep 4, 2024
4a57ac1
updated build number
ftegenfe Sep 4, 2024
abcce90
conflict fixed
ftegenfe Sep 5, 2024
808c3db
patch not needed anymore
ftegenfe Sep 5, 2024
e80419c
patch not needed anymore
ftegenfe Sep 5, 2024
82ffa61
update for new package with macos fix
ftegenfe Sep 5, 2024
59be8ff
updated tests and macos fix
ftegenfe Sep 5, 2024
0c40c01
new sha256sum
ftegenfe Sep 5, 2024
573d5c4
Merge branch 'master' into master
ftegenfe Sep 5, 2024
735906b
orthologer 3.3.2
ftegenfe Sep 5, 2024
80eb339
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Sep 5, 2024
86551c8
orthologer 3.3.2 - build number reset
ftegenfe Sep 5, 2024
75dcae5
sed macos, do not do in place edit
ftegenfe Sep 6, 2024
8261edd
require bash 4.1 - will this work for macos?
ftegenfe Sep 6, 2024
e45e7c0
orthologer 3.3.2 - bash shebang update (macos)
ftegenfe Sep 6, 2024
51a9aa4
merge
ftegenfe Sep 6, 2024
5318135
Merge branch 'master' into master
ftegenfe Sep 6, 2024
e3c70f5
Merge branch 'bioconda:master' into master
ftegenfe Sep 6, 2024
0d6400b
updated description
ftegenfe Sep 10, 2024
fd5c5cc
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Sep 10, 2024
8d71f36
version 3.4.0
ftegenfe Sep 12, 2024
3d57bc6
upd 3.4.0
ftegenfe Sep 12, 2024
7a97f24
upd 3.4.0
ftegenfe Sep 12, 2024
95baab1
upd 3.4.0
ftegenfe Sep 12, 2024
15bd48c
upd 3.4.0
ftegenfe Sep 13, 2024
b61eb54
merge
ftegenfe Sep 13, 2024
274bdbc
upd 3.4.0
ftegenfe Sep 13, 2024
d1a6d16
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Sep 13, 2024
1bb2411
upd 3.4.0
ftegenfe Sep 13, 2024
23eca95
version 3.4.1
ftegenfe Sep 13, 2024
15d41ec
merge
ftegenfe Sep 13, 2024
e233d9e
merge
ftegenfe Sep 17, 2024
c34ceb6
update summary
ftegenfe Sep 17, 2024
05b40e3
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Oct 1, 2024
a769112
update to orthologer 3.4.2
ftegenfe Oct 3, 2024
0d96419
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Oct 3, 2024
b0ed1cf
update license in meta.yaml
ftegenfe Oct 3, 2024
7440f5f
added busco dep
ftegenfe Oct 7, 2024
73263b8
update to 3.5.0
ftegenfe Oct 9, 2024
2f04e3a
updated orthologer meta
ftegenfe Oct 9, 2024
9ae11da
updated orthologer meta
ftegenfe Oct 9, 2024
6c29000
updated orthologer meta
ftegenfe Oct 9, 2024
7b07203
added orthodb api
ftegenfe Nov 6, 2024
cb5196c
Merge branch 'bioconda:master' into master
ftegenfe Nov 6, 2024
6e64a6f
Merge branch 'bioconda:master' into master
ftegenfe Nov 6, 2024
4d41d22
fixes according to coderabbit - remove bash requirements
ftegenfe Nov 6, 2024
862004f
Merge branch 'bioconda:master' into master
ftegenfe Nov 6, 2024
ec7e152
updated requirements
ftegenfe Nov 6, 2024
8c9e428
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Nov 6, 2024
2364fd9
upd requirements (requests)
ftegenfe Nov 6, 2024
2e54c99
fix meta.yaml
ftegenfe Nov 6, 2024
231052a
upd python ver
ftegenfe Nov 6, 2024
12c268c
run_exports readded
ftegenfe Nov 6, 2024
75525a5
Merge branch 'bioconda:master' into master
ftegenfe Nov 6, 2024
c359434
run_exports readded
ftegenfe Nov 6, 2024
1989848
Merge branch 'master' of github.com:ftegenfe/bioconda-recipes-fork
ftegenfe Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipes/orthodb/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
$PYTHON -m pip install . --no-deps --ignore-installed -vv
51 changes: 51 additions & 0 deletions recipes/orthodb/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{% set name = "orthodb" %}
{% set version = "0.9.0" %}
{% set sha256 = "b1c776e5521c809245696c0c6388f3301d10966707774fc7fecaa4cd40481bd3" %}

package:
name: {{ name }}
version: {{ version }}

build:
number: 0
noarch: python
run_exports:
- {{ pin_subpackage('orthodb', max_pin="x") }}

Comment on lines +9 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove unnecessary run_exports configuration

The run_exports section is typically used for compiled libraries where ABI compatibility matters. For a pure Python package, this configuration is unnecessary and could potentially constrain downstream packages unnecessarily.

 build:
   number: 0
   noarch: python
-  run_exports:
-    - {{ pin_subpackage('orthodb', max_pin="x") }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
build:
number: 0
noarch: python
run_exports:
- {{ pin_subpackage('orthodb', max_pin="x") }}
build:
number: 0
noarch: python

source:
url: https://gitlab.com/ezlab/orthodb_py/-/archive/{{ version }}/orthodb_py-{{ version }}.tar.gz
sha256: {{ sha256 }}

requirements:
build:
- python >=3.9
- bash >=4.1
host:
- python >=3.9
- pip
- bash >=4.1
run:
- python >=3.9
- bash >=4.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Remove unnecessary Bash dependency requirements

The package only uses Bash in the build script with a simple pip install command that doesn't require any Bash-specific features. The build.sh could easily use sh instead. The Bash dependency in all sections (build, host, run) is unnecessary since:

  1. The package itself is a pure Python package
  2. The build script doesn't use any Bash-specific features
  3. No other shell scripts or Bash usage was found in the package

Please remove the Bash requirements from all sections and fix the trailing whitespace on line 30.

🔗 Analysis chain

Verify Bash dependency requirement.

The inclusion of Bash >=4.1 as a requirement in all sections (build, host, run) is unusual for a Python package. Please verify if this is actually needed for the package functionality.

Also, there's a trailing whitespace on line 30 that should be removed.


Let me generate additional scripts to check for bash script usage specifically in the orthodb package.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the package actually uses bash in its code
rg -l 'subprocess.*bash|os.system.*bash' || echo "No direct bash usage found"

# Check if there are any shell scripts in the package
ast-grep --pattern 'from subprocess import|import subprocess'

Length of output: 11022


Script:

#!/bin/bash
# Check for shell scripts in the orthodb package directory
fd -e sh . recipes/orthodb/

# Check for bash shebang in any files
rg '^#!.*bash' recipes/orthodb/

# Check build.sh and any other scripts for bash-specific features
cat recipes/orthodb/build.sh || echo "No build.sh found"

Length of output: 226

🧰 Tools
🪛 yamllint

[error] 30-30: trailing spaces

(trailing-spaces)

test:
commands:
- python -c 'import orthodb; api=orthodb.OdbAPI();'

about:
home: https://www.ezlab.org/orthodb_v12_userguide.html
license: GPL3
license_family: GPL3
license_file: LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add license file to the files section

The license_file is specified but there's no files section to ensure it's included in the package.

Add this section after the source section:

files:
  - LICENSE

summary: Interface to OrthoDB REST API.
description: Python interface to OrthoDB REST API with some additional functionality.
dev_url: https://gitlab.com/ezlab/orthodb_py
doc_url: https://www.ezlab.org/orthodb_v12_userguide.html#api

extra:
identifiers:
- biotools:orthodb
- doi:10.1093/nar/gkac996
- PMID:36350662
recipe-maintainers:
- ftegenfe
Loading