Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding RDEVAL #52070

Merged
merged 32 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions recipes/rdeval/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/usr/bin/env bash

set -o errexit
set -o nounset
set -o xtrace

make

# mkdir -vp "${PREFIX}/bin"

# Define installation manifest
declare -A files=(
["rdeval"]="0755"
)

# Install files
for file in "${!files[@]}"; do
if [[ ! -f "$SRC_DIR/$file" ]]; then
echo "Source file $file not found in $SRC_DIR" >&2
exit 1
fi

if ! install -v -m "${files[$file]}" "$SRC_DIR/$file" "$PREFIX/bin/$file"; then
echo "Failed to install $file" >&2
exit 1
fi
done
31 changes: 31 additions & 0 deletions recipes/rdeval/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{% set name = "rdeval" %}
{% set version = "0.0.2" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/vgl-hub/{{ name }}/archive/refs/tags/v{{ version }}.zip
sha256: 466ff3dd3f80aa544be4e0992d1d46bbde933279413392cf17a1fe3b6c2fc5be

requirements:
build:
- {{ compiler('cxx') }}
- make

build:
number: 0
run_exports:
- {{ pin_subpackage(name|lower, max_pin="x.x") }}

test:
commands:
- ${PREFIX}/bin/rdeval --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance test coverage

The current test only verifies that the help command works. Consider adding more comprehensive tests:

  1. Test basic functionality with sample input
  2. Verify output format
  3. Test error handling

Would you like assistance in generating additional test commands based on the tool's functionality?


about:
home: https://github.com/vgl-hub/{{ name }}
summary: A general purpose, multithreaded read analysis and manipulation tool.
license: MIT
license_file: LICENSE
license_url: https://github.com/vgl-hub/{{ name }}/blob/main/LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

LICENSE file verified and README requires a detailed Description section

  • The LICENSE file exists and is compliant with the MIT License.
  • README.md lacks a detailed Description section as recommended.
🔗 Analysis chain

Verify license file and update summary

  1. Please verify that the LICENSE file exists in the source package.
  2. Consider expanding the summary to mention:
    • The specific types of read analysis it supports
    • Its relevance to bioinformatics (since this is for Bioconda)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify license file existence and content
gh api repos/vgl-hub/rdeval/contents/LICENSE --jq '.content' | base64 -d

# Check if there's a more detailed description in README
gh api repos/vgl-hub/rdeval/contents/README.md --jq '.content' | base64 -d | grep -A 5 "^#.*Description"

Length of output: 298


Script:

#!/bin/bash
# Verify license file existence and content without using base64
gh api repos/vgl-hub/rdeval/contents/LICENSE --raw

# Check if there's a more detailed description in README
gh api repos/vgl-hub/rdeval/contents/README.md --raw | grep -A 5 "^#.*Description"

Length of output: 2865


Script:

#!/bin/bash
# Verify license file existence and content using jq to decode base64
gh api repos/vgl-hub/rdeval/contents/LICENSE --jq '.content | @base64d'

# Check if there's a more detailed description in README using jq to decode and grep for keywords
gh api repos/vgl-hub/rdeval/contents/README.md --jq '.content | @base64d' | grep -A 5 "^#.*Description"

Length of output: 1244

Loading