Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding RDEVAL #52070

Merged
merged 32 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions recipes/rdeval/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#!/usr/bin/env bash

set -o errexit
set -o nounset
set -o xtrace

make

# mkdir -vp "${PREFIX}/bin"

# # Define installation manifest
# declare -A files=(
# ["bam_depth.sh"]="0755"
# ["halfdeep.sh"]="0755"
# ["halfdeep.r"]="0755"
# ["scaffold_lengths.py"]="0755"
# )

# # Install files
# for file in "${!files[@]}"; do
# if [[ ! -f "$SRC_DIR/$file" ]]; then
# echo "Source file $file not found in $SRC_DIR" >&2
# exit 1
# fi
#
# if ! install -v -m "${files[$file]}" "$SRC_DIR/$file" "$PREFIX/bin/$file"; then
# echo "Failed to install $file" >&2
# exit 1
# fi
# done
31 changes: 31 additions & 0 deletions recipes/rdeval/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{% set name = "rdeval" %}
{% set version = "0.0.2" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/vgl-hub/{{ name }}/archive/refs/tags/v{{ version }}.zip
sha256: 78500c88efa48f62f1907301bf36c9b689bd6933a59bd4a38974f0af393ed541

requirements:
build:
- {{ compiler('cxx') }}
- make

build:
number: 0
run_exports:
- {{ pin_subpackage(name|lower, max_pin="x.x") }}

test:
commands:
- ${PREFIX}/bin/genodsp --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Naming inconsistency between binary and package

The binary name genodsp in recipes/rdeval/meta.yaml differs from the package name rdeval. Please verify if this is intentional and update for consistency if necessary.

🔗 Analysis chain

Enhance test coverage and clarify binary name

Two concerns:

  1. The test only verifies that the help command works. Consider adding more comprehensive tests.
  2. The binary name genodsp differs from the package name rdeval. Please clarify if this is intentional.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check source code for available command-line options
rg -g '*.cpp' -g '*.h' 'add_option|getopt' -A 5

# Look for test files in the source repository
fd -g '*test*'

Length of output: 9627


about:
home: https://github.com/vgl-hub/{{ name }}
summary: A general purpose, multithreaded read analysis and manipulation tool.
license: MIT
license_file: LICENSE
license_url: https://github.com/vgl-hub/{{ name }}/blob/main/LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

LICENSE file verified and README requires a detailed Description section

  • The LICENSE file exists and is compliant with the MIT License.
  • README.md lacks a detailed Description section as recommended.
🔗 Analysis chain

Verify license file and update summary

  1. Please verify that the LICENSE file exists in the source package.
  2. Consider expanding the summary to mention:
    • The specific types of read analysis it supports
    • Its relevance to bioinformatics (since this is for Bioconda)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify license file existence and content
gh api repos/vgl-hub/rdeval/contents/LICENSE --jq '.content' | base64 -d

# Check if there's a more detailed description in README
gh api repos/vgl-hub/rdeval/contents/README.md --jq '.content' | base64 -d | grep -A 5 "^#.*Description"

Length of output: 298


Script:

#!/bin/bash
# Verify license file existence and content without using base64
gh api repos/vgl-hub/rdeval/contents/LICENSE --raw

# Check if there's a more detailed description in README
gh api repos/vgl-hub/rdeval/contents/README.md --raw | grep -A 5 "^#.*Description"

Length of output: 2865


Script:

#!/bin/bash
# Verify license file existence and content using jq to decode base64
gh api repos/vgl-hub/rdeval/contents/LICENSE --jq '.content | @base64d'

# Check if there's a more detailed description in README using jq to decode and grep for keywords
gh api repos/vgl-hub/rdeval/contents/README.md --jq '.content | @base64d' | grep -A 5 "^#.*Description"

Length of output: 1244

Loading