fix: disabling composite actions/feedbacks removes contents #3200

bitfocus · Jan 6, 2025 · df6aa66 · df6aa66
1 parent 303e7ea
commit df6aa66
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/companion/lib/Controls/Fragments/FragmentActionInstance.ts b/companion/lib/Controls/Fragments/FragmentActionInstance.ts
@@ -148,7 +148,7 @@ export class FragmentActionInstance {
 	}
 
 	/**
-	 * Inform the instance of a removed action
+	 * Inform the instance of a removed/disabled action
 	 */
 	cleanup() {
 		// Inform relevant module

diff --git a/companion/lib/Controls/Fragments/FragmentActionList.ts b/companion/lib/Controls/Fragments/FragmentActionList.ts
@@ -82,14 +82,13 @@ export class FragmentActionList {
 	}
 
 	/**
-	 * Inform the instance of any removed actions
+	 * Inform the instance of any removed/disabled actions
 	 * @access public
 	 */
 	cleanup() {
 		for (const action of this.#actions) {
 			action.cleanup()
 		}
-		this.#actions = []
 	}
 
 	/**

diff --git a/companion/lib/Controls/Fragments/FragmentFeedbackInstance.ts b/companion/lib/Controls/Fragments/FragmentFeedbackInstance.ts
@@ -154,7 +154,7 @@ export class FragmentFeedbackInstance {
 	}
 
 	/**
-	 * Inform the instance of a removed feedback
+	 * Inform the instance of a removed/disabled feedback
 	 */
 	cleanup() {
 		// Inform relevant module

diff --git a/companion/lib/Controls/Fragments/FragmentFeedbackList.ts b/companion/lib/Controls/Fragments/FragmentFeedbackList.ts
@@ -121,14 +121,13 @@ export class FragmentFeedbackList {
 	}
 
 	/**
-	 * Inform the instance of any removed feedbacks
+	 * Inform the instance of any removed/disabled feedbacks
 	 * @access public
 	 */
 	cleanup() {
 		for (const feedback of this.#feedbacks) {
 			feedback.cleanup()
 		}
-		this.#feedbacks = []
 	}
 
 	/**