Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: indiciate variables support on input field #2583

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Sep 20, 2023

This is a pretty small change, that I think will help users. I am not 100% sold on the look, if anyone has ideas on how to improve it please do say

A simple indicator to show that the input field supports variables. On hover it shows Supports variables. It is using the useVariables property to decide to show this, which matches how we decide whether to suggest variables while typing.

I am hoping that we can add more icons to both this field type and others over time to indicate support for other features that modules need to implement support for

image

@Julusian Julusian force-pushed the feat/indicate-variables-support branch from e18efe3 to 01398e3 Compare October 9, 2023 21:14
@Julusian Julusian merged commit 47872c4 into beta Oct 9, 2023
9 checks passed
Julusian added a commit that referenced this pull request Oct 10, 2023
@MeestorX
Copy link

MeestorX commented Nov 6, 2023

Can you also add this icon to dropdowns when allowCustom is enabled, as it allows for variables too.
Another request to PLEASE add variable support for ALL input types. Numbers, Checkboxes, etc.

@Julusian
Copy link
Member Author

Julusian commented Nov 6, 2023

Can you also add this icon to dropdowns when allowCustom is enabled, as it allows for variables too.

Any suggestion on what icon should be used for allowCustom?

Another request to PLEASE add variable support for ALL input types. Numbers, Checkboxes, etc.

The architectural challenges blocking this don't have a solution yet

@Julusian Julusian deleted the feat/indicate-variables-support branch November 6, 2023 19:12
@MeestorX
Copy link

MeestorX commented Nov 6, 2023

Can you also add this icon to dropdowns when allowCustom is enabled, as it allows for variables too.

Any suggestion on what icon should be used for allowCustom?

I think the same icon would be fine.

Another request to PLEASE add variable support for ALL input types. Numbers, Checkboxes, etc.

The architectural challenges blocking this don't have a solution yet

Copy that. NP.

@dnmeid
Copy link
Member

dnmeid commented Nov 6, 2023

@MeestorX your request is already on my todo list for a long time: #2345

@Julusian
Copy link
Member Author

Julusian commented Nov 7, 2023

Can you also add this icon to dropdowns when allowCustom is enabled, as it allows for variables too.

Any suggestion on what icon should be used for allowCustom?

I think the same icon would be fine.

I'm not sure it should be the same, as there is no guarantee that allowCustom means that variables can be used.
But an allowVariables option could be added to the dropdowns to show that icon, with a different icon shown if it supports allowCustom, once we figure out what that icon should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants