Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove differences from flathub flatpak manifest and devel manifest #12555

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 23, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Cleans up some of the difference between the flatpak manifests between flathub (https://github.com/flathub/com.bitwarden.desktop/blob/master/com.bitwarden.desktop.yaml) and the devel build.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ db4d7435-8013-4870-9e42-3fcfd951fd00

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-11115 Npm-electron-33.2.1 Vulnerable Package

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 33.78%. Comparing base (395258d) to head (cee0706).

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12555      +/-   ##
==========================================
- Coverage   33.79%   33.78%   -0.01%     
==========================================
  Files        2912     2912              
  Lines       90701    90701              
  Branches    17153    17153              
==========================================
- Hits        30648    30641       -7     
- Misses      57667    57674       +7     
  Partials     2386     2386              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant