Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to match new behaviour after removing gulp #469

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 8, 2024

📔 Objective

Update to match the behaviour after bitwarden/clients#11861

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from justindbaur November 8, 2024 09:23
@Hinton Hinton requested a review from a team as a code owner November 8, 2024 09:23
Copy link

github-actions bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Detailsfc8750cd-2f7b-4132-9c22-20c6778438bc

No New Or Fixed Issues Found

withinfocus
withinfocus previously approved these changes Nov 8, 2024
docs/getting-started/clients/browser/index.md Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2024

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d07000f
Status: ✅  Deploy successful!
Preview URL: https://b86481cb.contributing-docs.pages.dev
Branch Preview URL: https://remove-gulp.contributing-docs.pages.dev

View logs

@Hinton Hinton requested a review from withinfocus November 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants