Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace GPG signing recommendation with SSH #507

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Conversation

audreyality
Copy link
Member

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

Now that GitHub's SSH key signing support has matured, recommend using an SSH key for commit verification.

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner December 26, 2024 16:46
Copy link

cloudflare-workers-and-pages bot commented Dec 26, 2024

Deploying contributing-docs with ย Cloudflare Pages ย Cloudflare Pages

Latest commit: 72d55e5
Status:ย โœ…ย  Deploy successful!
Preview URL: https://c6fc076b.contributing-docs.pages.dev
Branch Preview URL: https://recommend-ssh.contributing-docs.pages.dev

View logs

This comment was marked as resolved.

withinfocus
withinfocus previously approved these changes Dec 30, 2024
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, and something I am already doing personally.

docs/contributing/commit-signing.mdx Outdated Show resolved Hide resolved
docs/contributing/commit-signing.mdx Outdated Show resolved Hide resolved
@audreyality audreyality merged commit 756f6a3 into main Dec 30, 2024
9 checks passed
@audreyality audreyality deleted the recommend-ssh branch December 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants