Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation #703

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

initial implementation #703

wants to merge 1 commit into from

Conversation

BTreston
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from eliykat December 27, 2024 15:19
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 87734e7e-f57b-4aa4-9262-9657e6ab852c

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Use_Of_Hardcoded_Password /src/services/sync.service.spec.ts: 137 Attack Vector

@BTreston
Copy link
Contributor Author

@eliykat Whenever you're back and able to give this first pass a look over, I just had a few questions:

  • it seems like jest doesnt like ECMAScript Modules (which are used in the googleapis) and plugging it into the existing transformer in the jest config didn't seem to fix it. Not sure how to handle the resulting error.
  • stripe has a cap on how large a transaction can be (999,999.99 USD) so there's a soft limit to how many users you can have it seems. Have we run into this before?
  • in terms of batching groups, do we want to batch based on the number of groups, or the number of users within the groups?

I also still have a few todo's:

  • More testing for the sync service (ie. for generateNewHash, buildRequests)
  • Refactor the sync call into more testable pieces, potentially move some code that might not belong in this service (looking at some of the directory stuff in this service)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant