Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide global coverage configuration #634

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Provide global coverage configuration #634

merged 1 commit into from
Feb 27, 2024

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Feb 27, 2024

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Codecov says it merges global and local configs, but looks like it doesn't. Provides global status configuration so this doesn't fail checks.

Code changes

  • .github/codecov.yml: Checks configuration addition.

Before you submit

  • Please add unit tests where it makes sense to do so

@withinfocus withinfocus marked this pull request as ready for review February 27, 2024 17:23
@withinfocus withinfocus requested a review from Hinton February 27, 2024 17:23
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details57cf4033-9ae2-4551-8c78-3df0d1e6a477

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.50%. Comparing base (d1fe6b7) to head (ed3ad39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   59.50%   59.50%           
=======================================
  Files         171      171           
  Lines       10416    10416           
=======================================
  Hits         6198     6198           
  Misses       4218     4218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton merged commit e9b77a4 into main Feb 27, 2024
59 checks passed
@Hinton Hinton deleted the codecov branch February 27, 2024 17:39
Hinton pushed a commit that referenced this pull request Feb 29, 2024
Reverts #634 and #636 as we found our mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants