Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease test coverage #635

Closed
wants to merge 4 commits into from
Closed

Decrease test coverage #635

wants to merge 4 commits into from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 27, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please add unit tests where it makes sense to do so

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.70%. Comparing base (cdfb9fa) to head (594aa02).

Files Patch % Lines
crates/bitwarden/src/mobile/crypto.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   59.50%   55.70%   -3.81%     
==========================================
  Files         171      171              
  Lines       10416    10283     -133     
==========================================
- Hits         6198     5728     -470     
- Misses       4218     4555     +337     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 27, 2024

Logo
Checkmarx One – Scan Summary & Detailse0a0dfc2-5357-4ac5-b7a2-de9ff83da7ff

No New Or Fixed Issues Found

@withinfocus withinfocus deleted the ps/fail-test branch February 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants