Use same version for bitwarden crates #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 173 173
Lines 10518 10518
=======================================
Hits 6385 6385
Misses 4133 4133 ☔ View full report in Codecov by Sentry. |
Hinton
force-pushed
the
cargo-tie-versions
branch
from
1c58d91 to
06e09b7
Compare
|
New Issues
Fixed Issues
|
vgrassia
previously approved these changes
Mar 18, 2024
Hinton
changed the title
# Conflicts: # crates/bitwarden-json/Cargo.toml # crates/bws/Cargo.toml # crates/sdk-schemas/Cargo.toml
michalchecinski
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Rather than maintaining separate versions for every crate let's keep them locked. That means the rust sdk packages will always have the same version. Unfortunately a side effect of this is that every package will be released even if that package hasn't changed.
Before you submit