Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14243] Free organization limit is not enforced when editing user #5155

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Dec 16, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14243

📔 Objective

Enforce the free organization limit when editing a user. Add unit tests to verify this enforcement during organization creation and member acceptance flows.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome changed the title Ac/pm 14243/free organization limit is not enforced when editing user [PM-14243] Free organization limit is not enforced when editing user Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.00%. Comparing base (d0c72a3) to head (87ea92a).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...OrganizationUsers/UpdateOrganizationUserCommand.cs 58.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5155      +/-   ##
==========================================
+ Coverage   42.98%   43.00%   +0.01%     
==========================================
  Files        1446     1446              
  Lines       66150    66160      +10     
  Branches     6060     6063       +3     
==========================================
+ Hits        28437    28454      +17     
+ Misses      36431    36421      -10     
- Partials     1282     1285       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Logo
Checkmarx One – Scan Summary & Details02ffa0ad-9ba6-4806-b801-4990d0eb33e5

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /build.yml: 686 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 638 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 601 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build.yml: 600
LOW Unpinned Actions Full Length Commit SHA /build.yml: 685
LOW Unpinned Actions Full Length Commit SHA /build.yml: 637

@r-tome r-tome marked this pull request as ready for review December 17, 2024 10:05
@r-tome r-tome requested a review from a team as a code owner December 17, 2024 10:05
@r-tome r-tome requested a review from BTreston December 17, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants