Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic-routing): update dynamic routing to use localstorage instead #6405

Closed
wants to merge 1 commit into from

Conversation

jjBlockchain
Copy link
Contributor

Description (optional)

Add a concise explanation of the changes.

Testing Steps (optional)

Detail the steps required for the reviewer(s) to verify and test these changes.

@@ -21,7 +21,7 @@ const SuperAppLink = () => {
const hasSuperAppAccess = cookies.get('wallet_v5_ui_available')

const handleClick = () => {
cookies.set('opt_out_wallet_v5_ui', 'false', { domain: '.blockchain.com', path: '/' })
localStorage.setItem('wallet_v5_ui_available', 'false')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt_out_wallet_v5_ui

@@ -21,7 +21,7 @@ const SuperAppLink = () => {
const hasSuperAppAccess = cookies.get('wallet_v5_ui_available')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localStorage

@CTucker-BC CTucker-BC closed this Jul 9, 2024
@sstephanou-bc
Copy link

Logo
Checkmarx One – Scan Summary & Details7c91efb4-7aa9-4765-b253-51c941b6918d

Fixed Issues

Severity Issue Source File / Package
LOW Unprotected_Cookie /packages/blockchain-wallet-v4-frontend/src/scenes/app.tsx: 178
LOW Unprotected_Cookie /packages/blockchain-wallet-v4-frontend/src/scenes/app.tsx: 197

@jjBlockchain jjBlockchain deleted the fix/dynamic-routing branch July 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants