Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allow imports to be cleaned and sorted automatically on file save. It also adds an
engine
property to NodeJS packages, ensuring proper compatibility for users of our packages.eslint-plugin-import
recommended rules to eslint configimport/order
rule to force consistent orderingeslint-plugin-n
to make sure the features we use are consistent with the node version we support (>=18.7.0)engines: { node: ">=18.7.0" }
to all packages meant for NodeJSNote
The supported NodeJS version is currently stated to be 18.0.0 but our code relies on features only available since 18.7.0. For this reason, the
engines
fields was updated to require NodeJS 18.7.0.Note
This PR adds an
engine
field to all NodeJS packages to ensure that users of the@atproto
packages can be notified by their package manager if their version of NodeJS might cause compatibility issues.