lex-cli: Fix TS Errors with codegen #3282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes type-only imports as well as other strict errors with codegen output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes for the TypeScript Errors (#3230, #3231, #3232) that I encountered with the lex-cli codegen output.
The specific changes are:
ts-morphto^24.0.0isTypeOnlyto named imports in codegen where relevanthasPropThe new codegen output should be functionally the same (if it was working before, it should still work). I tried to avoid making any breaking changes.
I'm already using this patched version of lex-cli for a personal project.
The fix to
hasPropwill conflict with #2956. Adding an explicit$typeproperty and removinghasPropis probably the better long term solution, but I didn't want to make any breaking changes.