DS-1053: Update data array #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmriv
commented
Oct 4, 2023
| @@ -275,6 +275,28 @@ public static function buildPropsArray($items, $schema, $isData = FALSE) { | |||
| } | |||
| } | |||
|
|
|||
| if ($isData) { | |||
There was a problem hiding this comment.
Moved this logic to Utils.php as requested here https://gitlab.com/pegadigital/bolt/design-system/-/merge_requests/172/diffs#abc6908e4ce44dffaf341cb178f23e9d085294ce_236_247
danielamorse
reviewed
Oct 5, 2023
|
I think we are saying this Github version is the new source of truth @danielamorse, because it can be pulled into Drupal (unlike the Bolt version, which would require a release). I think by "moved this logic", Andrew is talking about it going from one file (twigFunctions.php) to another (Utils.php), which was my suggestion when I first reviewed this in the other (Gitlab designsystem) PR. @andrewmriv, please correct me if I'm off here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.