Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: modify logo variable #759

Merged
merged 1 commit into from
Dec 9, 2024
Merged

docs: modify logo variable #759

merged 1 commit into from
Dec 9, 2024

Conversation

sdarwin
Copy link
Contributor

@sdarwin sdarwin commented Dec 9, 2024

When building the docs with Sphinx 8.1.3 there is an error about 'logo'.

Where is the variable originally defined?

The modification in this PR seems to solve the problem.

@mloskot
Copy link
Member

mloskot commented Dec 9, 2024

Where is the variable originally defined?

Possibly a bug!

Thank you!

@mloskot mloskot merged commit 7c554ac into boostorg:develop Dec 9, 2024
17 of 18 checks passed
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (322c4e2) to head (2f470fb).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #759      +/-   ##
===========================================
+ Coverage    82.12%   82.46%   +0.34%     
===========================================
  Files          117      117              
  Lines         5355     5727     +372     
===========================================
+ Hits          4398     4723     +325     
- Misses         957     1004      +47     

@sdarwin
Copy link
Contributor Author

sdarwin commented Dec 10, 2024

Thanks. RemovedInSphinx90Warning warnings (not errors) also appeared. I have not researched them.

writing output... [ 2%] design/basics
/opt/venvboostdocs/lib/python3.12/site-packages/sphinx/builders/html/init.py:1076: RemovedInSphinx90Warning: The str interface for _JavaScript objects is deprecated. Use js.filename instead.
if resource and '://' in otheruri:
/opt/venvboostdocs/lib/python3.12/site-packages/sphinx/util/osutil.py:48: RemovedInSphinx90Warning: The str interface for _JavaScript objects is deprecated. Use js.filename instead.
if to.startswith(SEP):
/opt/venvboostdocs/lib/python3.12/site-packages/sphinx/util/osutil.py:51: RemovedInSphinx90Warning: The str interface for _JavaScript objects is deprecated. Use js.filename instead.
t2 = to.split('#')[0].split(SEP)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants