Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modular build structure. #172

Merged
merged 25 commits into from
Sep 1, 2024

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

@grafikrobot grafikrobot marked this pull request as ready for review August 18, 2024 15:24
@grafikrobot
Copy link
Member Author

Please review and merge this PR at your earliest convenience.

@apolukhin
Copy link
Member

@grafikrobot could you please take another look at this PR. Something is wrong with CI runs. I've failed to quickly diagnose the problem, may be your experience would find the issue quickly?

…g. Testing was already linking the correct libs.
@grafikrobot
Copy link
Member Author

@grafikrobot could you please take another look at this PR. Something is wrong with CI runs. I've failed to quickly diagnose the problem, may be your experience would find the issue quickly?

Figured out the problem. I had inadvertently added /boost/stacktrace//boost_stacktrace as a dependency for all the tests. Which made the linker choose the noop version instead of the specific one each test wants. Should be resolved now.

@coveralls
Copy link

Coverage Status

coverage: 86.35%. remained the same
when pulling 7f29662 on grafikrobot:modular
into cbf0df7 on boostorg:develop.

@apolukhin apolukhin merged commit ad121db into boostorg:develop Sep 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants