Reuse the endpoint of the checkpointed container when restore #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods for checkpointing and restoring containers were added to the native driver. The LXC driver returns an error message that these methods are not implemented yet. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: daemon/execdriver/native/create.go daemon/execdriver/native/driver.go daemon/execdriver/native/init.go
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Support was added to the daemon to use the Checkpoint and Restore methods of the native exec driver for checkpointing and restoring containers. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: api/server/server.go daemon/container.go daemon/daemon.go daemon/networkdriver/bridge/driver.go daemon/state.go vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
Restore failed if network resource not released during checkpoint, e.g., a container with port open with -p Signed-off-by: Hui Kang <[email protected]> Conflicts: daemon/container.go
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Add a basic test for checkpoint/restore to the integration tests Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Hui Kang <[email protected]>
|
@boucher This PR fixes the network endpoint problem when restoring a container. The endpoint should be reused by a checkpointed container so that the network resources (e.g., iptable rule) will not be changed after restoring. Please review if it fits into your branch. Thanks. |
|
If I run this code, and then checkpoint and restore a container, it still can't access the network. I believe this is related to the issue I filed here: moby#14027 (To test, I just exec'd into the restored container and tried ping'ing google.com) Are you actually able to use the network after a restore? |
Methods for checkpointing and restoring containers were added to the native driver. The LXC driver returns an error message that these methods are not implemented yet. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: daemon/execdriver/native/create.go daemon/execdriver/native/driver.go daemon/execdriver/native/init.go
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Support was added to the daemon to use the Checkpoint and Restore methods of the native exec driver for checkpointing and restoring containers. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: api/server/server.go daemon/container.go daemon/daemon.go daemon/networkdriver/bridge/driver.go daemon/state.go vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
Restore failed if network resource not released during checkpoint, e.g., a container with port open with -p Signed-off-by: Hui Kang <[email protected]> Conflicts: daemon/container.go
boucher
force-pushed
the
cr-combined
branch
3 times, most recently
from
7bc31ef to
af5a67b
Compare
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Add a basic test for checkpoint/restore to the integration tests Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Docker-DCO-1.1-Signed-off-by: Hui Kang <[email protected]> Merge branch 'cr-combined' into cr-combined-ep-fix Conflicts: daemon/container.go daemon/container_linux.go
|
@boucher Update the patch for 1.8.0-dev, but the problem you described still exists. I will look into this issue these days. |
Methods for checkpointing and restoring containers were added to the native driver. The LXC driver returns an error message that these methods are not implemented yet. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: daemon/execdriver/native/create.go daemon/execdriver/native/driver.go daemon/execdriver/native/init.go
Docker-DCO-1.1-Signed-off-by: Ross Boucher <[email protected]> (github: boucher)
Support was added to the daemon to use the Checkpoint and Restore methods of the native exec driver for checkpointing and restoring containers. Signed-off-by: Saied Kazemi <[email protected]> Conflicts: api/server/server.go daemon/container.go daemon/daemon.go daemon/networkdriver/bridge/driver.go daemon/state.go vendor/src/github.com/docker/libnetwork/ipallocator/allocator.go
Restore failed if network resource not released during checkpoint, e.g., a container with port open with -p Signed-off-by: Hui Kang <[email protected]> Conflicts: daemon/container.go
boucher
force-pushed
the
cr-combined
branch
4 times, most recently
from
8f69143 to
59c375a
Compare
boucher
force-pushed
the
cr-combined
branch
5 times, most recently
from
5dda3d1 to
183488f
Compare
boucher
force-pushed
the
cr-combined
branch
4 times, most recently
from
e91c518 to
988a915
Compare
boucher
force-pushed
the
cr-combined
branch
2 times, most recently
from
b584b5a to
a6a4511
Compare
boucher
force-pushed
the
cr-combined
branch
4 times, most recently
from
7c96921 to
7fda470
Compare
boucher
force-pushed
the
cr-combined
branch
8 times, most recently
from
d80f2fb to
9272300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-DCO-1.1-Signed-off-by: Hui Kang [email protected]