Webpack builds! #608

gesa · 2020-03-18T05:49:31Z

Summary

TODO:

add eslint runner
set up dev server
setup a jest file transformer for html imports (webpack doesn't support the fs module, but does have an html loader)
create dev, prod, & shared webpack config

Checklist

Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@gesa

gesa

some updates on the state and some questions too

gesa · 2020-03-23T18:32:21Z

.eslintrc

+    "node": true
+  },
+  "globals": {
+    "__dirname": true


i think maybe we don't need this if the env object includes "node": true? will check that out.

gesa · 2020-03-23T18:32:44Z

.eslintrc

+    "__dirname": true
+  },
+  "rules": {
+    "valid-jsdoc": [


have i ever mentioned how much i love that we are sticklers with our jsdoc? bc i do.

gesa · 2020-03-23T18:33:53Z

.eslintrc

+        "requireReturnDescription": true
+      }
+    ],
+    "object-curly-spacing": [


once i add prettier and have it autorun we can presumably delete this rule since it'll never come up. @crookedneighbor you good with that plan? i should add it to the next PR i do, right?

gesa · 2020-03-23T20:18:37Z

jsdoc/jsdoc.conf.js

@@ -0,0 +1,14 @@
+const { version } = require('../package.json');


Historically we were literally dynamically generating this file and then using fs.writeFile() which made sense at the time but maybe it's more maintainable to have a standalone conf.

gesa · 2020-03-23T20:19:47Z

package.json

    "del": "^5.1.0",
    "dotenv": "^8.2.0",
    "es6-shim": "^0.35.5",
    "eslint": "^6.8.0",
    "eslint-config-braintree": "^4.0.0",
+    "eslint-loader": "^3.0.3",


honestly i haven't decided if I want webpack to run this or if we should run it independently in posttest or the like. what it comes down to is i'd rather CI run it first, but locally run it last.

Could always run it in webpack and have CI run a npm run lint task directly that is not a pre or post task for tests.

gesa · 2020-03-23T20:20:16Z

package.json

    "serve-static": "^1.14.1",
+    "string-replace-loader": "^2.2.0",
+    "style-loader": "^1.1.3",
+    "symlink-webpack-plugin": "github:gesa/symlink-webpack-plugin#e661f2d64590a3cacba42d4f3c8a36f8d6dff1e4",


my changes to this lib got merged in, just waiting for a new release

Did this ever get released?

looks like it https://github.com/hmsk/symlink-webpack-plugin/releases/tag/v1.0.0

Suggested change

"symlink-webpack-plugin": "github:gesa/symlink-webpack-plugin#e661f2d64590a3cacba42d4f3c8a36f8d6dff1e4",

"symlink-webpack-plugin": "^1.0.0",

gesa · 2020-03-23T20:21:52Z

src/dropin.js

@@ -734,7 +733,7 @@ Dropin.prototype._injectStylesheet = function () {

  if (document.getElementById(constants.STYLESHEET_ID)) { return; }

-  stylesheetUrl = ASSETS_URL + '/web/dropin/' + VERSION + '/css/dropin@DOT_MIN.css';
+  stylesheetUrl = ASSETS_URL + '/web/dropin/' + VERSION + '/css/dropin.css';


why publish a minified and a non-minified version when we also throw all the javascript files in the npm release as-is? trying to decide how to prioritize publishing both.

Can you clarify this? The intention before was to load the minified css from the cdn when using the minified version on the cdn, and the un-minified version when using the un-minified version.

I do wonder now if folks using the build from npm always got the un-minified css assets.

gesa · 2020-03-23T20:24:22Z

test/app/index.html

@@ -229,7 +229,7 @@ <h1>Braintree Drop-in demo</h1>
    results.textContent = '';
    error.textContent = '';

-    braintree.dropin.create(config, function (err, instance) {
+    dropin.create(config, function (err, instance) {


THIS WILL BE THE DEATH OF ME. talk about a breaking change. browserify treats an option relating to how to name one's library in a parsey way—the string braintree.dropin becomes window.braintree.dropin. webpack treats that string like window['braintree.dropin']

there may be a clever way to deal with this but if i can get away with it i'd prefer not trying to be clever.

I think it's pretty important to keep everything name-spaced under braintree. Surely there's a way to do that, right?

gesa · 2020-03-23T20:26:30Z

webpack.config.js

+
+module.exports = {
+  devServer: {
+    allowedHosts: ['.bt.local'],


idk if this is necessary, meaningful, or helpful.

gesa · 2020-03-23T20:36:33Z

webpack.config.js

+    }
+  },
+  output: {
+    library: 'dropin',


this is that field where braintree.dropin vs dropin becomes a thing.

TODO: - add eslint runner - set up dev server - setup a jest file transformer for html imports (webpack doesn't support the fs module, but does have an html loader)

…requires* a project to have typescript

* Test app accessibility fix * Update changelog Co-authored-by: adelavegaruiz <[email protected]>

* update braintree-web to 3.85.5 * add changelog entry * update browser detection * no carrot * fix install issue Co-authored-by: cdibble <[email protected]>

Co-authored-by: Braintree <[email protected]>

* chore: update dependencies * chore: add jest-environment-jsdom dependency

Co-authored-by: Braintree <[email protected]>

) * fix: hide field errors and check for validity again on blur events * fix: clear field error on card type change Co-authored-by: Braintree <[email protected]>

armandodlvr · 2022-11-16T15:57:36Z

closing this PR in favor of #844

shango420 · 2022-11-18T15:11:53Z

closing this PR in favor of #844

gesa commented Mar 23, 2020

View reviewed changes

gesa and others added 19 commits October 15, 2020 13:41

Webpack builds!

0a35386

TODO: - add eslint runner - set up dev server - setup a jest file transformer for html imports (webpack doesn't support the fs module, but does have an html loader)

Use HTML loader for jest tests

e4b1aac

Add eslint to builds

a4f70d2

dev server!

528e887

fixup: use server logging method

f4de169

fixup: ignoring these eslint warns for now anyway

5a9aeae

Remove version reference variables from finished product

baee3dd

scrub version placeholders

b5a4ba9

fixup: package-lock update

ad0828d

fixup: not using del package anymore

b623238

remove browserify

e66b630

remove gulp

ac375b3

Update copy & fix jsdoc destination

3bf6455

Webpack 5

471dc0d

Update symlink plugin version

23f52a4

Updated jsdoc template allows us to drop that plugin i cobbled together

859769e

Delete unused packages

0db8c12

additional retired packages

4c85fab

don't need interpolator now that we have postprocessor

c587c77

gesa force-pushed the webpack branch from 4bce4f5 to c587c77 Compare October 15, 2020 23:58

gesa and others added 9 commits October 15, 2020 17:29

Simplify the eslintrc. I tried to use the next v5 but it definitely *…

060732d

…requires* a project to have typescript

production builds?

bd1eb0c

Rewrite html transformer to work on linux too

b08bbd6

feat: add support for Venmo Desktop (#684)

04f671b

chore: update dependencies (#685)

b7efb42

chore: update version numbers

0044c61

1.26.0

9d532d8

chore: Update Google Pay mark to match brand guidelines

6574421

Update braintree-web to v3.71.1

a69cafe

cgdibble and others added 27 commits May 27, 2022 10:50

Release version 1.33.2

337d755

1.33.2

33a084b

Update version to 1.33.2

ce3e355

1.33.2

25f5529

Merge branch 'release' into main

84d5cd4

fix: test app accessibility errors (#818)

800a9e5

* Test app accessibility fix * Update changelog Co-authored-by: adelavegaruiz <[email protected]>

chore: update braintree-web to 3.85.5 (#821)

696684a

* update braintree-web to 3.85.5 * add changelog entry * update browser detection * no carrot * fix install issue Co-authored-by: cdibble <[email protected]>

Update version to 1.33.3

c6103f9

1.33.3

c89bb75

chore: update to braintree-web 3.86.0 (#822)

a42cb70

Co-authored-by: Braintree <[email protected]>

Update version to 1.33.4

89cad35

1.33.4

2607b2a

chore: update dependencies (#835)

8e9a1b7

* chore: update dependencies * chore: add jest-environment-jsdom dependency

chore: run npm audit fix

1a58708

chore: remove hint (#839)

cdc3f0a

chore: update braintree-web to 3.88.3 (#840)

12adf79

Update version to 1.33.5

d7eefed

1.33.5

6b587f2

Update version to 1.33.6

df0ee6b

1.33.6

044c209

fix: update check for PayPal Credit presence (#843)

ff34521

Co-authored-by: Braintree <[email protected]>

fix: hide field errors and check for validity again on blur events (#842

857398d

) * fix: hide field errors and check for validity again on blur events * fix: clear field error on card type change Co-authored-by: Braintree <[email protected]>

Update version to 1.33.7

1dbc3e4

1.33.7

b06b3ef

update to webpack 5.75.0 and dependencies

b060046

clean up webpack and eslint conf

bdd736f

Merge branch 'main' into webpack

b5a79d7

armandodlvr closed this Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpack builds! #608

Webpack builds! #608

gesa commented Mar 18, 2020 •

edited by armandodlvr

Loading

gesa left a comment

gesa Mar 23, 2020

gesa Mar 23, 2020

gesa Mar 23, 2020

gesa Mar 23, 2020

gesa Mar 23, 2020

crookedneighbor Sep 15, 2020

gesa Mar 23, 2020

crookedneighbor Sep 15, 2020

gesa Sep 18, 2020

gesa Mar 23, 2020

crookedneighbor Sep 15, 2020

gesa Mar 23, 2020

gesa Mar 23, 2020

crookedneighbor Sep 15, 2020

gesa Mar 23, 2020

gesa Mar 23, 2020

armandodlvr commented Nov 16, 2022

shango420 commented Nov 18, 2022

		@@ -0,0 +1,14 @@
		const { version } = require('../package.json');

	"symlink-webpack-plugin": "github:gesa/symlink-webpack-plugin#e661f2d64590a3cacba42d4f3c8a36f8d6dff1e4",
	"symlink-webpack-plugin": "^1.0.0",

Webpack builds! #608

Webpack builds! #608

Conversation

gesa commented Mar 18, 2020 • edited by armandodlvr Loading

Summary

Checklist

Authors

gesa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

armandodlvr commented Nov 16, 2022

shango420 commented Nov 18, 2022

gesa commented Mar 18, 2020 •

edited by armandodlvr

Loading