Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient refactor and clean up #1242

Merged
merged 1 commit into from
Dec 17, 2024
Merged

HttpClient refactor and clean up #1242

merged 1 commit into from
Dec 17, 2024

Conversation

tdchow
Copy link
Collaborator

@tdchow tdchow commented Dec 16, 2024

Summary of changes

  • Rename HttpClient.getNumRetriesSoFar() to getCurrentRetryCount
  • Convert HttpClientUnitTest to Kotlin
  • Remove unused function and test class

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@tdchow
Rename HttpClient.getNumRetriesSoFar to getCurrentRetryCount, convert…
ead5aa8 
… HttpClientUnitTest to Kotlin, and remove unused function and test class
@tdchow tdchow requested a review from a team as a code owner December 16, 2024 17:40
@tdchow tdchow merged commit a74fe2b into main Dec 17, 2024
3 checks passed
@tdchow tdchow deleted the httpclient-refactor branch December 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdchow @jaxdesmarais @sarahkoop